test(charts): add helm-unittest suite for ingestion-authz-configmap#207
Open
saadqbal wants to merge 1 commit into
Open
test(charts): add helm-unittest suite for ingestion-authz-configmap#207saadqbal wants to merge 1 commit into
saadqbal wants to merge 1 commit into
Conversation
Covers the previously-untested templates/ingestion-authz-configmap.yaml — the authorization policy that gates POST /internal/submit-ingestion-run on jobs-manager (client-runtime#21). 8 tests assert: release-scoped naming, standard labels, the default wildcard policy entry, verbatim rendering of explicit multi-prefix entries, the per-entry service_account fallback to ingestionAuthz.serviceAccountName (#129), per-entry namespace defaulting to the release namespace, and the fail-safe deny-all behaviour when ingestionAuthz (or its allowed list) is absent from a --reuse-values upgrade. Tests-only; no source/template/values changes. Security invariants unchanged. Refs #193 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
👋 Heads-up — Code review queue is at 17 / 8 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a helm-unittest suite for the previously-untested
templates/ingestion-authz-configmap.yaml.This ConfigMap is the authorization policy that decides which ServiceAccount(s) may call
POST /internal/submit-ingestion-runon jobs-manager, scoped to table-name prefixes (client-runtime#21). jobs-manager loads it at startup as the single source of truth, so its fail-safe behaviour and fallbacks are security-relevant.Coverage delta
ingestion-authz-configmap) — chart suites 15 → 16The suite asserts:
RELEASE-NAME-ingestion-authz) + namespacetracebloc.labels"*")service_accountfallback toingestionAuthz.serviceAccountName(Move ingestor ServiceAccount into parent client chart (shared resource) #129)namespacedefaulting to the release namespaceingestionAuthzis absent (pre-feat(#86): ingestor Helm subchart + companion RBAC/service/authz for new ingestion endpoint #123--reuse-valuesupgrade) → emptyallowed:, noservice_accountingestionAuthz.allowedis emptyNotes
Refs #193
Note
Low Risk
Test-only change with no runtime or policy template modifications.
Overview
Adds a helm-unittest suite for
templates/ingestion-authz-configmap.yaml, which was previously untested. The chart gains 8 cases (167 total tests) that lock in ConfigMap metadata/labels, default wildcard policy rendering, explicit multi-prefix entries,service_accountfallback toingestionAuthz.serviceAccountName, omittednamespacedefaulting to the release namespace, and fail-safe deny-all wheningestionAuthzis null orallowedis empty.Tests only — no Helm template or values changes; behavior is asserted, not modified.
Reviewed by Cursor Bugbot for commit b7f0b2d. Bugbot is set up for automated code reviews on this repo. Configure here.