Conversation
feat(secrets): wire POD_TOKEN_SIGNING_SECRET for stateless pod tokens (client-runtime#79)
Contributor
|
👋 Heads-up — Code review queue is at 15 / 8 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
shujaatTracebloc
approved these changes
Jun 4, 2026
aptracebloc
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the stateless-token chart wiring (#205) from
developtomain, so it can be released to the Pages channel.Included (1 commit)
POD_TOKEN_SIGNING_SECRETinsecrets.yaml(stable vialookup), env wiring into jobs-manager + requests-proxy,podTokenSigningSecret/podTokenTtlSecondsvalues, version 1.4.5 → 1.5.0.Rollout ordering (important)
The chart secret only activates stateless mode when the running images carry the mint/verify code (client-runtime#89). Recommended order:
develop → staging → master(Prod: Implement self-upgrade CronJob for Helm chart automation #90 then staging→master) so:prodimages have docs(claude): require @saadqbal as PR assignee #79.Safe either way: if 1.5.0 reaches a fleet whose images predate #79, the secret is simply ignored and the deployment stays in legacy
pod_tokensmode (no breakage) until the image catches up.Validation
Stateless mode validated live on the
tracebloc-amazoncanary — 10 experiments through stop-storm churn, every proxy post200, zero401. See client-runtime#88.Refs client-runtime#79, client-runtime#89, #205, #204.
🤖 Generated with Claude Code
Note
Medium Risk
Touches authentication-related secrets and deployment env across jobs-manager and requests-proxy; misconfigured TTL or secret rotation could invalidate live training tokens, though legacy behavior remains if images predate the runtime support.
Overview
Chart release 1.5.0 promotes Helm wiring for client-runtime#79: a shared HMAC secret so jobs-manager can mint and requests-proxy can verify per-pod
REQUESTS_PROXY_TOKENwithout the legacypod_tokenstable.The chart adds
POD_TOKEN_SIGNING_SECRETto the main client Secret with upgrade-stable resolution (explicitpodTokenSigningSecret, else preserve vialookup, else generate on first install). jobs-manager getsPOD_TOKEN_SIGNING_SECRETplusPOD_TOKEN_TTL_SECONDS(default 7 days); requests-proxy gets the same signing secret for stateless verification. New valuespodTokenSigningSecretandpodTokenTtlSecondsdocument operator pin/rotation and TTL backstop behavior.Stateless mode only takes effect when running images include the mint/verify logic; older images ignore the new env vars and stay on legacy mode until upgraded.
Reviewed by Cursor Bugbot for commit 013a88b. Bugbot is set up for automated code reviews on this repo. Configure here.