fix: address Bugbot findings from PR #22 (target_size order + Makefile/CI lint parity)#25
Merged
Merged
Conversation
1. target_size: emit [height, width] (was [width, height]) to match the ingest.v1 schema + ingestor; only affected non-square datasets. Added TestBuild_TargetSize_EmittedHeightWidth (non-square) regression test. 2. Makefile: make ci lint now runs the same standalone tools as CI (errcheck + ineffassign + misspell) instead of golangci-lint, restoring the local==CI invariant while golangci-lint-action stays disabled (#6); golangci-lint moved to make lint-full. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
👋 Heads-up — Code review queue is at 13 / 8 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
saadqbal
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the two Cursor Bugbot findings raised on the
develop → mainsync PR #22. Per our flow, the fixes land ondevelophere; #22 then picks them up automatically and the Bugbot threads resolve.1.
target_sizeemitted as[width, height]— schema/ingestor want[height, width](Medium)The embedded
ingest.v1.jsondocumentstarget_sizeas[height, width]and the ingestor reads it that way, butbuildImagewrote[width, height](the order from--target-size WxH/DetectImageSize). Square datasets were unaffected — which is why it slipped through — but non-square datasets would pass local validation yet mis-validate resolution in the ingestor.spec.file_options) to[height, width]; kept the user-facing--target-size WxHflag and the auto-detect message unchanged.TestBuild_TargetSize_EmittedHeightWidth— a non-square (640×480→[480, 640]) regression test, since square sizes can't catch a swap.2.
make cilint diverged from CI lint (Medium)make lintrangolangci-lint, while CI's lint job runserrcheck+gofmt -s+ineffassign+misspell(golangci-lint-action is disabled pending #6). The Makefile exists specifically to keep local == CI.make lint(used bymake ci) now runs the same standalone tools as CI (gofmt -sisfmt-check,go vetisvet), restoring the "make ci green ⟹ CI green" invariant.make lint-fullfor an optional richer pass; re-unifying on it is tracked in Re-enable staticcheck + unused linters once we have a strategy for the k8s.io dep tree #6.Verification
make cigreen end-to-end:go vet,go test -race, the new standalone lint,fmt-check, andschema-check(no drift).🤖 Generated with Claude Code
Note
Medium Risk
Changes dataset push spec output for non-square resolutions (fixes ingestor mis-validation) and redefines local lint to match CI; both affect correctness and developer workflow but not auth or data paths directly.
Overview
Ingest spec
target_sizeorder:buildImagenow emits[height, width](schema/ingestor order) whileSpecArgs.TargetSizestays[W, H]from--target-size/ auto-detect. Both emit paths swap on output: keypoint top-leveltarget_sizeand imagespec.file_options.target_size. Comments onTargetSizedocument the storage vs emit convention.Regression test:
TestBuild_TargetSize_EmittedHeightWidthuses 640×480 so stored[640, 480]must become[480, 640]forimage_classificationand "and"keypoint_detection(square sizes would not catch a width/height swap).Makefile / CI parity:
make lint(part ofmake ci) runs the same standalone tools as.github/workflows/build.yml—errcheck,ineffassign, andmisspellviago run— instead ofgolangci-lint.make lint-fullkeeps the optionalgolangci-lint runpass until golangci-lint-action is re-enabled (#6).Reviewed by Cursor Bugbot for commit 34e1755. Bugbot is set up for automated code reviews on this repo. Configure here.