test(cli): integration harness for the real-I/O seams (kind e2e)#17
Merged
Conversation
Contributor
Author
|
👋 Heads-up — Code review queue is at 21 / 8 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
This was referenced Jun 2, 2026
The unit suite mocks every cluster boundary, leaving the highest-risk
code — the SPDYExecutor tar-over-exec stream — at 0% coverage. Every
live bug this project hit (staging<->DEST collision, validator drift,
schema skew) was only findable by running it by hand. This adds an
automated integration harness against a real cluster.
- test/integration/ (//go:build integration):
* Connectivity — cluster.Load + NewClientset against a live API server.
* StageAndVerify — creates a throwaway namespace + PVC + stage pod,
streams a dataset via the REAL push.SPDYExecutor tar-over-exec, then
exec's back into the pod to confirm the files landed. Covers
SPDYExecutor.Exec + StreamLayout + CreateStagePod /
WaitForStagePodReady — the seams with zero unit coverage.
- Makefile: `make test-integration` (ambient kubeconfig; -count=1,
build-tagged).
- .github/workflows/e2e.yml: boots kind + runs the suite. Gated to
nightly / manual dispatch / `e2e`-labeled PRs (kind boot is too heavy
to run per-PR).
Validated locally against a live k3d cluster: both tests pass; the
stream lands files on the PVC and the exec-back confirms content. The
files are build-tag-gated, so normal `go test ./...` and the CI test
job are unaffected. The kind CI job gets its first real run on the
nightly schedule / manual dispatch / an `e2e`-labeled PR.
Follow-ups (test/integration/README.md): a PortForwardJobsManager
fixture; a full `dataset push` through a real jobs-manager + ingestor
(needs the chart in-cluster) to catch cross-component schema skew e2e.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
705ab2b to
df97034
Compare
5 tasks
aptracebloc
approved these changes
Jun 2, 2026
Contributor
aptracebloc
left a comment
There was a problem hiding this comment.
Rebased onto develop — schema-drift green. Labeled e2e to actually run the harness: Integration (kind) PASSES, so the SPDYExecutor + StreamLayout tar-over-exec seam compiles and works end-to-end on a real kind cluster — the coverage gap I flagged is now closed. All other checks green. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing safety net under the CLI's real-I/O code — the seams the mock-based unit suite can't reach, where every live bug actually lived (
SPDYExecutor.Execis 0% in unit coverage). Independent of the modality stack; branches offdevelop.What it adds
test/integration/(//go:build integration):cluster.Load+NewClientsetagainst a live API server.SPDYExecutortar-over-exec, then exec's back into the pod to confirm the files landed. CoversSPDYExecutor.Exec,StreamLayout,CreateStagePod,WaitForStagePodReady.make test-integration— runs against your ambient kubeconfig (kind, k3d, any dev cluster)..github/workflows/e2e.yml— boots kind + runs the suite, gated to nightly / manual /e2e-labeled PRs (kind boot is too heavy per-PR).Validation
Ran locally against a live k3d cluster — both tests pass; the stream lands files on the PVC and the exec-back confirms content (
filename,label / 001.jpg). Build-tag-gated, sogo test ./...and the CItestjob are unaffected.Why this matters
This harness covers the exact code path behind the staging↔DEST collision, the validator drift, and the schema skew — all of which were only caught by manual live runs this cycle. Follow-ups (in the harness README): a PortForward fixture and a full
dataset pushthrough a real jobs-manager + ingestor to catch cross-component schema skew end-to-end.🤖 Generated with Claude Code