Skip to content

[1.8] Miscellaneous cleanups - #320

Open
Oondanomala wants to merge 1 commit into
tr7zw:1.8from
Oondanomala:1.8-random-cleanups
Open

[1.8] Miscellaneous cleanups#320
Oondanomala wants to merge 1 commit into
tr7zw:1.8from
Oondanomala:1.8-random-cleanups

Conversation

@Oondanomala

Copy link
Copy Markdown

This is my excuse for procrastinating working on other mods :D

  • Updated loom, Gradle, and shadow
  • Cleaned up build script a bit
  • Do not require the mod to be presents on other clients (happens with LAN worlds)
  • Replaced EntityRendererInter with a proper accessor mixin
  • Added prefixes to Cullable's method names to avoid method conflicts
  • Made CullableMixin's fields @Unique for the same reason
  • Optimize nametag rendering a bit by not calling canRenderName as renderName already checks it
  • Micro optimization in WorldRendererMixin, avoid calling getEntityRenderObject when renderNametagsThroughWalls is disabled

Also, given how its been months, it would be nice if you made a new release on modrinth for 1.8, so people can actually benefit from the changes.

This is my excuse for procrastinating working on other mods

Notable changes:
Do not require other clients to be using the mod when hosting a world
Optimize nametag rendering a bit by not checking canRenderName as renderName does it for us
Avoid calling getEntityRenderObject when  not necessary
Avoid potential mixin conflicts
@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9d49eff1-4a7e-4e36-82d0-c620b35db669

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@tr7zw

tr7zw commented Aug 16, 2026

Copy link
Copy Markdown
Owner

I'll look into it, seeing how I got a handful of PRs for 1.8/1.12/1.7.10, I think I should setup a compose setup to better maintain these build steps and potentially unify these 3 versions. Might be an interesting task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants