[1.8] Miscellaneous cleanups - #320
Conversation
This is my excuse for procrastinating working on other mods Notable changes: Do not require other clients to be using the mod when hosting a world Optimize nametag rendering a bit by not checking canRenderName as renderName does it for us Avoid calling getEntityRenderObject when not necessary Avoid potential mixin conflicts
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
I'll look into it, seeing how I got a handful of PRs for 1.8/1.12/1.7.10, I think I should setup a compose setup to better maintain these build steps and potentially unify these 3 versions. Might be an interesting task. |



This is my excuse for procrastinating working on other mods :D
EntityRendererInterwith a proper accessor mixinCullable's method names to avoid method conflictsCullableMixin's fields@Uniquefor the same reasoncanRenderNameasrenderNamealready checks itWorldRendererMixin, avoid callinggetEntityRenderObjectwhenrenderNametagsThroughWallsis disabledAlso, given how its been months, it would be nice if you made a new release on modrinth for
1.8, so people can actually benefit from the changes.