Skip to content

recompressed icon to reduce filesize - #311

Closed
BRAiNS4GAMES wants to merge 1 commit into
tr7zw:mainfrom
BRAiNS4GAMES:main
Closed

recompressed icon to reduce filesize#311
BRAiNS4GAMES wants to merge 1 commit into
tr7zw:mainfrom
BRAiNS4GAMES:main

Conversation

@BRAiNS4GAMES

Copy link
Copy Markdown

No description provided.

recompressed icon to reduce filesize
@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • src/main/resources/icon.png is excluded by !**/*.png

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: de3c290f-7a3e-46e4-ad4e-7d76754c8e5b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tr7zw

tr7zw commented Aug 14, 2026

Copy link
Copy Markdown
Owner

I started adding a contributors file to the projects, as I don't think this is a great road to go down. Anyone could throw the icon into another online tool to further shave kb off the file like:
icon(1)
which is 200kb smaller. But that doesn't add anything to the mod, it is not an improvement, it doesn't fix anything. So to prevent going down an endless spiral of "I shaved a few more kb of this image", I will not accept them in the first place, worst-case just do it all once myself.
Hope you do understand why, and thanks for the PR. I'll close the others too.

@BRAiNS4GAMES

Copy link
Copy Markdown
Author

As if you were getting PRs with carefully recompressed images all the time. The improvement would have been a reduced mod file size. Thanks for dumping my work. It was not done using yet another online tool. Just try to achieve the same lossless compression level for all files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants