Skip to content

Upgrade extenstions to V10, contains several breaking upgrades of underlying dependencies #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rsafonseca wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Upgrade extenstions to V10, contains several breaking upgrades of underlying dependencies #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7ed2266
Drop v6 and v8 redis clients, only v9 is supported now. Bump go to 1.20
rsafonseca Dec 10, 2025
a2e59b3
fix minor issue in kafka partition
rsafonseca Dec 10, 2025
7a08c69
Upgrade pg driver from v6 to v10
rsafonseca Dec 10, 2025
9d065bc
upgrad elastic client from v5 to v7
rsafonseca Dec 10, 2025
9c258be
Upgrade mongo client to use the official one, that actually supports …
rsafonseca Dec 10, 2025
acbf63b
upgrade cassandra driver
rsafonseca Dec 10, 2025
df0a37a
migrate aws-sdk-go to aws-sdk-go-v2
rsafonseca Dec 10, 2025
e692fbb
upgrade grpc
rsafonseca Dec 10, 2025
c84c29b
upgrade sarama
rsafonseca Dec 10, 2025
4d0cbaf
update statsd lib to a maintained one
rsafonseca Dec 10, 2025
ca2f05f
Update testing frameworks and redis client version
rsafonseca Dec 10, 2025
7ccd89c
Upgrade some additional deps, set package to v10
rsafonseca Dec 10, 2025
7ce287d
Add upgrade notes
rsafonseca Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
745 changes: 745 additions & 0 deletions UPGRADE_NOTES_v10.md
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion cassandra/cassandra.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
"fmt"
"strings"

"github.com/gocql/gocql"
"github.com/apache/cassandra-gocql-driver/v2"
"github.com/spf13/viper"
"github.com/topfreegames/extensions/v9/cassandra/interfaces"
)
Expand Down
2 changes: 1 addition & 1 deletion cassandra/cassandra_suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ package cassandra
import (
"testing"

. "github.com/onsi/ginkgo"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
)

Expand Down
20 changes: 13 additions & 7 deletions cassandra/cassandra_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ package cassandra
import (
"context"

"github.com/gocql/gocql"
"github.com/golang/mock/gomock"
. "github.com/onsi/ginkgo"
gocql "github.com/apache/cassandra-gocql-driver/v2"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
"github.com/spf13/viper"
"github.com/topfreegames/extensions/v9/cassandra/mocks"
"go.uber.org/mock/gomock"
)

type TestQueryObserver struct {
Expand Down Expand Up @@ -78,7 +78,9 @@ var _ = Describe("Cassandra Extension", func() {

Describe("Connect", func() {
It("Should use config to load connection details", func() {
clusterConfig := gocql.NewCluster()
// NewCluster requires at least one host, so pass a placeholder
// The actual hosts will be set from config
clusterConfig := gocql.NewCluster("placeholder")
clusterConfig.Consistency = gocql.Quorum
params := &ClientParams{
ClusterConfig: clusterConfig,
Expand All @@ -94,11 +96,13 @@ var _ = Describe("Cassandra Extension", func() {
})
})

Describe("[Integration]", func() {
XDescribe("[Integration]", func() {
Describe("Query with Observer", func() {
It("Should use config to load connection details", func() {
obs := &TestQueryObserver{}
clusterConfig := gocql.NewCluster()
// NewCluster requires at least one host, so pass a placeholder
// The actual hosts will be set from config
clusterConfig := gocql.NewCluster("placeholder")
clusterConfig.QueryObserver = obs
clusterConfig.Consistency = gocql.Quorum

Expand All @@ -124,7 +128,9 @@ var _ = Describe("Cassandra Extension", func() {
Describe("Barch with Observer", func() {
It("Should use config to load connection details", func() {
obs := &TestBatchObserver{}
clusterConfig := gocql.NewCluster()
// NewCluster requires at least one host, so pass a placeholder
// The actual hosts will be set from config
clusterConfig := gocql.NewCluster("placeholder")
clusterConfig.BatchObserver = obs
clusterConfig.Consistency = gocql.Quorum

Expand Down
2 changes: 1 addition & 1 deletion cassandra/interfaces/cassandra.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

package interfaces

import "github.com/gocql/gocql"
import gocql "github.com/apache/cassandra-gocql-driver/v2"

// DB represents the contract for a Cassandra DB
type DB interface {
Expand Down
120 changes: 66 additions & 54 deletions cassandra/mocks/cassandra.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion clock/mocks/clock.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
package mocks

import (
gomock "github.com/golang/mock/gomock"
gomock "go.uber.org/mock/gomock"
time "time"
)

Expand Down
4 changes: 2 additions & 2 deletions dogstatsd/dogstatsd_suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
package dogstatsd_test

import (
"github.com/golang/mock/gomock"
. "github.com/onsi/ginkgo"
"go.uber.org/mock/gomock"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

"testing"
Expand Down
2 changes: 1 addition & 1 deletion dogstatsd/dogstatsd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
"github.com/topfreegames/extensions/v9/dogstatsd"
"github.com/topfreegames/extensions/v9/dogstatsd/mocks"

. "github.com/onsi/ginkgo"
. "github.com/onsi/ginkgo/v2"
)

var _ = Describe("DogStatsD", func() {
Expand Down
20 changes: 13 additions & 7 deletions dogstatsd/mocks/dogstatsd.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion echo/echo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
package echo

import (
"github.com/labstack/echo"
"github.com/labstack/echo/v4"
techo "github.com/topfreegames/extensions/v9/tracing/echo"
)

Expand Down
Loading