Skip to content
This repository was archived by the owner on Oct 13, 2026. It is now read-only.

docs: find the plugin root per host and check promotion in README (#153) - #154

Merged
lukemaj merged 1 commit into
mainfrom
docs/153-readme-install-gaps
Sep 29, 2026
Merged

lukemaj merged 1 commit into
mainfrom
docs/153-readme-install-gaps

Conversation

@lukemaj

@lukemaj lukemaj commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

What: The README install section now shows how to find MODEL_ROUTER_ROOT on Codex, Claude Code and Grok Build, lists the runner's requirements, and gives two commands that compare the latest release with the promoted Marketplace release.
Why: A second-opinion README review found three gaps: no way to find the installed plugin folder per host, requirements only as a link, and "once Toolybara promotes a release" with no way to check.
So what: Needs Luna max review, then the user's merge; the merge releases v0.44.1 (docs only, no behavior change).

Closes #153.

Changes

  • Requirements sentence (Python 3.11+, Git, reachable T3 server with a bearer token), linking RUNNER.md#requirements for the URL and token lookup order.
  • gh release view and a gh api read of Marketplace catalog.json to compare released and promoted tags.
  • Per-host MODEL_ROUTER_ROOT lookups with jq: Codex cache folder named by the version from codex plugin list --json; Claude Code installPath from claude plugin list --json; Grok Build path from grok plugin list --json.
  • Patch bump 0.44.0 -> 0.44.1.
  • Review round 1 (Luna max): added the provider-capability requirement and made the promotion check directional; folded into one versioned commit.

Proof

  • Each command run read-only on this Mac: both version commands print v0.44.0; the Codex lookup resolves the installed 0.44.0 root and bin/model-router --version runs. Model Router is not installed for Claude Code or Grok here, so those two queries were run with agentsmd substituted and returned ~/.claude/plugins/cache/toolboxmd/agentsmd/14.5.7 and ~/.grok/installed-plugins/agentsmd-1274b80f. No host config changed.
  • python3 scripts/test.py: 402 tests OK.
  • versionctl release-check: release candidate OK: v0.44.1 at cfd01e5e15811a753d3b71a0f4c1c30a6054e1fa.

Elon record

  • Requirements and who asked: planner via README: find MODEL_ROUTER_ROOT per host, list requirements, check release availability #153, from the 2026-09-30 README review findings.
  • Deleted: any README rewrite, a README/RUNNER sync test, and a CODEX_HOME variant (unverified here).
  • Bottleneck: a new user cannot set MODEL_ROUTER_ROOT without guessing the per-host folder.
  • Checked myself: ran every added command on this Mac against the live host CLIs, GitHub release, and Marketplace catalog.

🤖 Generated with Claude Code

@lukemaj

lukemaj commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

REQUEST CHANGES

Reviewed exact head a31acda34ecc4a431f9ce832f71bc90e4a3774d against Issue #153.

  1. [P2] README omits a required runner prerequisite (README.md:19-21). RUNNER.md's Requirements section also requires that the reachable T3 server's providers can run the configured routes. The README currently says only that the server is reachable and has a bearer token, so users can satisfy the listed requirements while every route remains unavailable. Please include the provider capability requirement (and keep this sentence aligned with RUNNER.md).

  2. [P2] Unequal tags do not establish that the newer release is unpromoted (README.md:34). This conclusion is valid only when the source release tag is newer than the Marketplace tag. If the Marketplace value is newer, it is already promoted; unequal strings alone do not distinguish the direction. Please qualify the comparison by direction, for example, say promotion is pending when the source release tag is newer.

Other checks: the Codex root query resolved to the installed 0.44.0 directory, and its documented --version and --help checks succeeded. Claude Code and Grok jq filters worked with agentsmd substituted as requested. The release and Marketplace queries both returned v0.44.0. The 0.44.1 VERSION and all three plugin manifests agree, and the 0.44.1 changelog entry describes the README-only changes. The native plugin installation commands were not run because they mutate host plugin state, which the review instructions prohibit. No changes outside the README, changelog, version, and plugin manifest bumps were found.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@lukemaj
lukemaj force-pushed the docs/153-readme-install-gaps branch 2 times, most recently from a31acda to cfd01e5 Compare September 29, 2026 22:58
@lukemaj

lukemaj commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

APPROVE

Reviewed the full PR at exact head cfd01e5e15811a753d3b71a0f4c1c30a6054e1fa against Issue #153.

The README now lists Python 3.11+, Git, a reachable Chromeria T3 server whose providers can run the routes, and the bearer token prerequisite; it links to RUNNER.md for URL and token lookup order. The comparison correctly says promotion is pending when the source release tag is newer than the Marketplace tag. Per-host root queries are present for Codex, Claude Code, and Grok, and the version/changelog changes are consistent at 0.44.1 across VERSION and all three plugin manifests.

Observed checks: both release comparison commands returned v0.44.0; the Codex query resolved to the installed 0.44.0 cache directory, and its documented --version and --help commands succeeded. Claude Code and Grok filters returned valid installed AgentsMD paths when substituted as instructed. The full PR diff contains only the README, changelog, version, and three manifest version changes. No blocking findings.

The native plugin installation commands were not run because they mutate host plugin state, which the review instructions prohibit.

@lukemaj
lukemaj merged commit 126b368 into main Sep 29, 2026
2 checks passed
@lukemaj
lukemaj deleted the docs/153-readme-install-gaps branch September 29, 2026 23:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README: find MODEL_ROUTER_ROOT per host, list requirements, check release availability

1 participant