This repository was archived by the owner on Oct 13, 2026. It is now read-only.
Repository navigation
Start Chromeria when T3 is down (#140); release 0.40.0 - #141
Merged
Merged
Conversation
After 60 continuous seconds without an answer, the T3 wait loop runs T3_LAUNCH_CMD (default /usr/bin/open -g -a Chromeria on macOS, off elsewhere, empty turns it off) once, then every 5 minutes. Each launch is a launching_t3 ledger event; a failed launch never ends the wait. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #140.
What changed
runner/controller.py_await_prism: while T3 is unreachable, once 60 continuous seconds have passed the loop runs the launch command once, then again every 5 minutes while T3 stays down. The existing backoff and the 24h cap stay as the backstop.T3_LAUNCH_CMDwhen set (empty or blank turns launching off); otherwise/usr/bin/open -g -a Chromeriaon macOS and off elsewhere. Run throughsubprocess.runonshlex.split(no shell), 15 second timeout.launching_t3ledger event instatuswithat,commandandresult(ok,exit N: <stderr>, or the exception). A failed launch never ends the wait.VERSION, three plugin.json mirrors,CHANGELOG.md,RUNNER.md.Timing note: the launch happens at the first reread after 60 seconds. With the 5/10/20/40/60 backoff that is 75 seconds, then 375, 675, and so on.
Test safety
Tests never start the real Chromeria:
Base.run_controllerintests/test_issue133.pynow replacescontroller._launch_t3with a recorder, andisolate_t3_envsetsT3_LAUNCH_CMD="".Proof
tests/test_issue140.py(fake clock, fake client, fake launcher): no launch before 60s; launch at 75s and the job continues once the read succeeds; relaunch at 375, 675, 975; failed launches recorded and the wait goes on; empty command disables launching._launch_t3checked against real harmless commands: success, nonzero exit, missing binary, bad quoting,;passed as an argument (no shell), timeout.uv run --with pytest python3 -m pytest -q: 328 passed, 30 subtests passed.python3 scripts/test.py: Ran 328 tests, OK.versionctl release-check: release candidate OK: v0.40.0 at 619b92b.Not checked: a live launch of Chromeria through the runner (not run, since the real app was in use).
🤖 Generated with Claude Code