Repository navigation
docs: correct triggers.md and add the trigger-benchmark method (#5) - #26
Merged
Merged
Conversation
Fix the four superpowers findings after re-checking obra/superpowers at 8ca22db and superpowers-evals at e64684c, add sections on when a description is not enough, routing rows and testing a trigger, and add docs/06-testing/trigger-benchmarks.md with the harness lessons from the AgentsMD routing benchmarks. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
REQUEST_CHANGES
|
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
APPROVE The #174 baseline wording at
|
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
triggers.mdno longer credits karpathy-wiki's SKIP and anti-rationalization shape to superpowers. It now also covers when a description is not enough, how to word routing rows, and how to test a trigger. A new page,docs/06-testing/trigger-benchmarks.md, gives the full trigger-benchmark method.Why: The repo's description reference got its main shape's source wrong, misstated length and over-firing, and had no valid method for testing a trigger. AgentsMD has since measured all of this.
So what: A reviewer checks the exact head, then the user merges.
Closes #5
Refs #7
Changes
docs/05-authoring/triggers.md: four corrections; new sections "When a description is not enough", "Routing rows" and "Test a trigger" (replaces the pressure-test loop); sources pinned.docs/06-testing/trigger-benchmarks.md(new): decision, fixture, cases and moments, confinement, instrument validity, interleaved arms, records, instrument checks. Every rule cites the case study or an AgentsMD PR or results file.docs/06-testing/unit-tests.md: trigger benchmarks are a fourth kind of test. Superpowers removedtests/skill-triggering/in8611a4e, and the page now says so. The "no CI" sentence is updated because Make the doc checks run: link check, llms.txt freshness and CI #10 merged: CI runsnpm test, not the validator.docs/06-testing/benchmark-integrity.md: one sentence linking the new page.docs.json, README Testing list, the loader Skill's map (new entry; the triggers entry was also updated because it described the old two-shape page).GLOSSARY.mdgains Arm.public/llms.txtregenerated.Superpowers lines re-checked (obra/superpowers
8ca22db, superpowers-evalse64684c)skills/writing-skills/SKILL.md:171,:546-552:103"Keep under 500 characters if possible"skills/*/SKILL.mddescriptions, parsed:152-154:140,RELEASE-NOTES.md:264:154-156AGENTS.md:76:582-583skill-not-called, vacuous-pass-beforeverbsdocs/scenario-authoring.md:520-524,:660-666docs/experiments/2026-09-02-opus5-signature.md:311-320tests/skill-triggering/8611a4eAgentsMD numbers and sources (records at
06b7af6)operationsdocs/work/164-trigger-audit/results.mddocs/work/174-routing-injection/results.mdmidtask.jsonl, #182--summary174-routing-injection/records-prefix.jsonl(Opus, arms A/B/C) andrecords.jsonl(B2, B3)182-routing-sweep/records.jsonl--summary, regeneratedThe Issue's "prose.md 7/22 against 22/22" comes only from the non-public #174 analysis quoted in #6. The public records do not reproduce it, so the page uses the recomputable 4/15 against 15/15 and marks those runs as read attempts.
Elon record
triggers.md); retelling the case study inside the method page (it links the case study); the Issue's 7/22 figure, which is not reproducible from public records.git archive 06b7af6; rannpm test.Proof
npm ci && npm test: exit 0 (links, llms.txt freshness and coverage, absolute paths, bare-path gate).npm run build:llmsregeneratedpublic/llms.txt.5d7e16f(qualify the #174 3/20 baseline), fixed inccaa79f, then APPROVE onccaa79f;review/independentissuccess.🤖 Generated with Claude Code