Repository navigation
Elon gate: also gate gh issue new and gh pr new #251
Description
What: The Elon gate also checks gh issue new and gh pr new, the documented aliases of create.
Why: gh_create() matches only the word create, so gh issue new --title x --body y creates an Issue with no Elon record and no hook block.
So what: Small fix for an implementation worker; independent review; Luke approves the merge.
Outcome
Every way gh creates an Issue or PR from the shell is gated the same way.
Evidence
gh help issue createandgh help pr createlist the aliasgh issue new/gh pr new.- On current main,
gh_create(['gh','issue','new','--title','x'])returnsNone, whilegh_create(['gh','issue','create','--title','x'])returnsissue(checked 2026-10-19 by importingbin/project-direction). - Found by the Muse Spark 1.3 review of PR fix: let gh create help through the Elon gate #250 (Elon gate: let gh issue|pr create --help through #247), noted as out of that Issue's scope.
Contribution to the Objective: the Elon record exists on every Issue and PR it is meant to cover.
Elon record
- Requirements and who asked: Luke's rule that every Issue and PR carries an Elon record, enforced by the hook; the gap was found during the 2026-10-19 review follow-up.
- Deleted: gating other
ghsubcommands or API paths beyond the documentednewalias. - Bottleneck: one word match in
gh_create(). - Checked myself: the
gh helpalias lines and thegh_create()results above.
Acceptance criteria
-
gh issue new …andgh pr new …are classified as creates and gated exactly likecreate, including the help exemption from Elon gate: let gh issue|pr create --help through #247. - Regression tests cover both aliases.
Non-goals
- Other gate changes.
Blockers
Coordinate with PR #250 (#247), which edits the same function; build on it after it merges or stack on it.
Required proof
- Tests failing before and passing after; full suite; independent review on the exact head; version transition per repository policy.
Activity
lukemaj commentedon Oct 19, 2026
What: Implemented together in #257 at
6ea958a7439c25a388ee7161def506b3f1dfd8a8.Why: Raw fail-closed checks cover alias and wrapped/dynamic recognition gaps before body extraction can authorize a hidden create.
So what: Deterministic proof is complete; independent review remains pending, with no reviewers started, before Luke approves merge.
Proof and the Elon record are in the PR: 148 failing-before assertions; real Bash with fake-gh argv logs; 468 repository tests and 7 versionctl tests passed; doctor and release-check passed; version 17.4.3 prepared and pushed. The PR documents accepted data false positives and the separate-body-file workaround. Zsh execution is unverified because Zsh is absent on bestia. No merge, release, tag or install performed.
lukemaj commentedon Oct 19, 2026
What: Revised implementation is pushed in #257 at
50b82dc12676156c995b350b7207cc3a25d23c50.Why: Confident single wrappers now receive their own normal record check, and literal commit/echo/printf text remains data; dynamic or nested execution still fails closed.
So what: All deterministic proof passes; independent review is pending, with no reviewers started, before Luke approves merge.
473 repository tests and 7 versionctl tests pass on the exact head; doctor and release-check pass. Version remains the PR's one 17.4.3 transition. The PR body documents the remaining exact data false positives and Zsh execution gap. Observer was republished as an explicitly session-scoped report after a default-ledger failure, tracked at toolboxmd/agent-observer#140. No merge, release, tag or install.
Proof correction: the earlier claim of 148 copied-baseline failures was a runner setup error because the sibling Python module was omitted. The corrected runner copies both files from each exact revision: current selected regressions produce 143 genuine bypass failures against original main
15b1dd5(exit 0 instead of 2), and 124 genuine overblocking failures against prior PR head6ea958a(exit 2 instead of 0). Both corrected runs have zero errors and no import failures; their results supersede that earlier count.