Skip to content

fix(wallets): fix logic in validUntil behavior #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shvandre merged 1 commit into from
Jun 1, 2026
+20 −50
Merged

fix(wallets): fix logic in validUntil behavior #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 20 additions & 50 deletions src/wallets/signing/createWalletTransfer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,16 +119,10 @@ export function createWalletTransferV2(args: {

// Create message
let signingMessage = beginCell().storeUint(args.seqno, 32);
if (args.seqno === 0) {
for (let i = 0; i < 32; i++) {
signingMessage.storeBit(1);
}
} else {
signingMessage.storeUint(
args.timeout || Math.floor(Date.now() / 1e3) + 60,
32,
); // Default timeout: 60 seconds
}
signingMessage.storeUint(
args.timeout || Math.floor(Date.now() / 1e3) + 60,
32,
); // Default timeout: 60 seconds
for (let m of args.messages) {
signingMessage.storeUint(args.sendMode, 8);
signingMessage.storeRef(beginCell().store(storeMessageRelaxed(m)));
Expand Down Expand Up @@ -160,16 +154,10 @@ export function createWalletTransferV3<

// Create message to sign
let signingMessage = beginCell().storeUint(args.walletId, 32);
if (args.seqno === 0) {
for (let i = 0; i < 32; i++) {
signingMessage.storeBit(1);
}
} else {
signingMessage.storeUint(
args.timeout || Math.floor(Date.now() / 1e3) + 60,
32,
); // Default timeout: 60 seconds
}
signingMessage.storeUint(
args.timeout || Math.floor(Date.now() / 1e3) + 60,
32,
); // Default timeout: 60 seconds
signingMessage.storeUint(args.seqno, 32);
for (let m of args.messages) {
signingMessage.storeUint(args.sendMode, 8);
Expand All @@ -187,16 +175,10 @@ export function createWalletTransferV4<
T extends WalletV4SendArgs & { action: OutActionWalletV4 },
>(args: T & { walletId: number; domain?: SignatureDomain }) {
let signingMessage = beginCell().storeUint(args.walletId, 32);
if (args.seqno === 0) {
for (let i = 0; i < 32; i++) {
signingMessage.storeBit(1);
}
} else {
signingMessage.storeUint(
args.timeout || Math.floor(Date.now() / 1e3) + 60,
32,
); // Default timeout: 60 seconds
}
signingMessage.storeUint(
args.timeout || Math.floor(Date.now() / 1e3) + 60,
32,
); // Default timeout: 60 seconds
signingMessage.storeUint(args.seqno, 32);
signingMessage.store(storeExtendedAction(args.action));

Expand Down Expand Up @@ -236,16 +218,10 @@ export function createWalletTransferV5Beta<T extends WalletV5BetaSendArgs>(
)
.store(args.walletId);

if (args.seqno === 0) {
for (let i = 0; i < 32; i++) {
signingMessage.storeBit(1);
}
} else {
signingMessage.storeUint(
args.timeout || Math.floor(Date.now() / 1e3) + 60,
32,
); // Default timeout: 60 seconds
}
signingMessage.storeUint(
args.timeout || Math.floor(Date.now() / 1e3) + 60,
32,
); // Default timeout: 60 seconds

signingMessage
.storeUint(args.seqno, 32)
Expand Down Expand Up @@ -291,16 +267,10 @@ export function createWalletTransferV5R1<T extends WalletV5R1SendArgs>(
)
.store(args.walletId);

if (args.seqno === 0) {
for (let i = 0; i < 32; i++) {
signingMessage.storeBit(1);
}
} else {
signingMessage.storeUint(
args.timeout || Math.floor(Date.now() / 1e3) + 60,
32,
); // Default timeout: 60 seconds
}
signingMessage.storeUint(
args.timeout || Math.floor(Date.now() / 1e3) + 60,
32,
); // Default timeout: 60 seconds

signingMessage
.storeUint(args.seqno, 32)
Expand Down