Repository navigation
test: cover excluded start bound in Bytes::slice - #864
Open
renanmpimentel wants to merge 1 commit into
Open
renanmpimentel wants to merge 1 commit into
renanmpimentel wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this test matters
Treating an excluded start bound as inclusive would return
ellinstead ofllfor the demonstrated slice. The new test protectsRangeBoundssemantics that the previous suite did not exercise.Supertest audit method
I used the Supertest test-audit skill to probe whether the existing suite would catch a plausible violation of this contract. The regression was applied only in an isolated worktree. The regression proof records three executed states: the existing tests pass with that regression, the new assertion fails against the same regression, and the new test passes with the original production code restored. The published diff adds tests only.
Change and verification
Adds a
Bytes::sliceregression case using an excluded start bound. Forb"hello",(Excluded(1), Excluded(4))must produceb"ll".Regression proof: treating an excluded start as inclusive leaves the existing all-feature integration suite passing, but this case fails with
b"ell". With production code restored,cargo test --all-featurespasses, including 248 doctests.cargo fmt --checkandcargo check --no-default-featuresalso pass.Clippy was run on all-feature tests with
-A clippy::reversed_empty_rangesbecause an existing out-of-range test intentionally uses5..3; the remaining pre-existing warnings do not fail the run. This PR changes tests only.Repository guidance
No contribution guide or PR template was present in the audited checkout. The all-feature tests, formatting and check passed; Clippy needed the documented allowance for an existing intentionally reversed range.