Repository navigation
ci: run nightly minimal-versions check and raise serde floor - #863
Open
princejain756 wants to merge 1 commit into
Open
princejain756 wants to merge 1 commit into
princejain756 wants to merge 1 commit into
Conversation
…s#851) Check the active rustc toolchain version in ci/test-stable.sh instead of the unset RUST_VERSION environment variable so the benchmark and minimal-versions checks run on the nightly CI job, and raise the minimum serde version from 1.0.60 to 1.0.70 where the alloc feature compiles cleanly.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #851
Since #452 removed
RUST_VERSIONfrom the workflow, the nightly block inci/test-stable.shhas been skipped becauseRUST_VERSIONis unset. In addition, runningcargo update -Z minimal-versionsresolvesserde1.0.60, which fails to compile with theallocfeature enabled (unresolved imports alloc::BTreeMap...).This change:
ci/test-stable.shusing the activerustcversion output so the benchmark and minimal-versions checks run on thenightlyCI job.serdedependency floor inCargo.tomlfrom1.0.60to1.0.70, the first release whereserdewithfeatures = ["alloc"]compiles underminimal-versions.