Repository navigation
Add #[inline] to BytesMut's BufMut::put_slice implementation - #860
Merged
Merged
Conversation
Darksonn
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While optimizing Rama, I noticed that calls to
BytesMut::put_slicethrough generic
BufMutcode remained out of line in optimized buildswithout cross-crate LTO.
The implementation simply delegates to
BytesMut::extend_from_slice,which already has
#[inline]. Adding the same attribute toput_sliceallows it to inline across the crate boundary.
Compiler Explorer reproduction:
the generic
BytesMutencoder retains calls toput_slice, while theequivalent
Vec<u8>encoder and directextend_from_slicecalls inline.The online example uses bytes 1.10.1. I also reproduced this locally
with bytes 1.12.1 and confirmed that adding only
#[inline]removesthe out-of-line
put_slicecalls.