Skip to content

Implement error bars using standard deviation on timeline plots#204

Open
str4d wants to merge 1 commit into
tobami:masterfrom
str4d:error-bars
Open

Implement error bars using standard deviation on timeline plots#204
str4d wants to merge 1 commit into
tobami:masterfrom
str4d:error-bars

Conversation

@str4d

@str4d str4d commented Jun 9, 2016

Copy link
Copy Markdown
Contributor

Recreated from #113 on current master.

@str4d

str4d commented Jun 9, 2016

Copy link
Copy Markdown
Contributor Author

Two things:

@tobami

tobami commented Jun 9, 2016

Copy link
Copy Markdown
Owner

Reviewing #203 ...

One thought occurred to me: before trying to re-add a complex feature like error bars, do you think it makes sense to reevaluate now what plotting library we use? jqPlot has been unmaintained for over two years now. flot is pretty similar and still widely used, if a bit simpler (may not have all the features). There are also other alternatives. Any thoughts here?

@str4d

str4d commented Jun 9, 2016

Copy link
Copy Markdown
Contributor Author

I don't personally have an opinion. I've never used any JavaScript plotting libraries prior to setting codespeed up; since then I have now used jqPlot and d3, but only just enough to get the features I wanted working 😜

@tobami

tobami commented Jun 9, 2016

Copy link
Copy Markdown
Owner

Ah, it seemed like you had experience with plotting libraries! Let's leave that question for now then.

@tobami

tobami commented Jul 31, 2016

Copy link
Copy Markdown
Owner

@str4d are you going to rebase this branch onto master?

@str4d

str4d commented Sep 13, 2016

Copy link
Copy Markdown
Contributor Author

Sorry for the delay, work's been keeping me busy. I'll do this Friday 😄

@tnorth

tnorth commented Oct 18, 2016

Copy link
Copy Markdown

I'm also interested in this change, therefore a kind ping @str4d :-)

@tnorth

tnorth commented Oct 20, 2016

Copy link
Copy Markdown

Ok, I merged it quickly, it works for me but since I don't know the internals of codespeed, I can't tell if I broke something.
The merge commits are here: https://github.com/tnorth/codespeed/commits/master

@tobami

tobami commented Oct 20, 2016

Copy link
Copy Markdown
Owner

Nice, thanks @tnorth! I'll do some "visual" testing of it 😄

@str4d

str4d commented Aug 22, 2017

Copy link
Copy Markdown
Contributor Author

Sorry for dropping the ball on this! I'll be doing some more codespeed work in the next few weeks, so I'll get this integrated while I do :)

@str4d

str4d commented Aug 22, 2017

Copy link
Copy Markdown
Contributor Author

Rebased on 0.11.0 (because that's what I've been working from locally), and fortunately there are no merge conflicts with master!

@tobami

tobami commented Aug 25, 2017

Copy link
Copy Markdown
Owner

Could you rebase on top of master just in case? I merged some big refactors affecting default branches.

jqplot.ohlcRendererWithErrorBars.min.js is the standard OHLC Renderer plugin
from jqPlot 1.0.9 (revision d96a669) with the error-bar addition given here:

https://bitbucket.org/cleonello/jqplot/issues/35/add-error-bar-capability#comment-141580
@str4d

str4d commented Aug 25, 2017

Copy link
Copy Markdown
Contributor Author

Rebased on master, still appears to work for me!

@tobami

tobami commented Aug 26, 2017

Copy link
Copy Markdown
Owner

I checked and the error bars are shown, well done! However, the padding has been increased.

Before:
image

After:
image

(this is with testdata.json)

@str4d

str4d commented Aug 26, 2017

Copy link
Copy Markdown
Contributor Author

That padding change appears to be left over from the original PR #113 (see e.g. #113 (comment)). I can try playing around with the contents, but not being the original author I don't immediately know the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants