Repository navigation
合入 GLM 工具调用修复并完成 v1.0.6 整体验证 - #129
Merged
Merged
Conversation
The wizard-ai gateway (aicoder-pro, GLM 5.2) sometimes fails to convert
GLM tool-call template markup into structured tool_calls under load, and
returns names like `skill_view(name="kimi-webbridge")</arg_value>` or an
empty name with `{}`. ACECode executed them as Unknown tool, wrote the
broken name back into history and echoed it in the error, so the model
copied it again (session 20261014-081557-766b looped for 13 rounds).
- Treat a step as corrupted output when a tool call has an empty name,
a non-conventional name carrying GLM markers or call syntax, or
arguments carrying template structure; reuse the existing discard and
retry-once path (response_corrupted_retry gains a context param).
- Do not echo empty or corrupted names in Unknown tool errors.
- History projection drops corrupted-name calls and turns their persisted
error results into a hidden "tool call not executed" user note, so the
request no longer ends on an orphaned assistant message.
- Describe skill_view / memory_read calls in prose instead of pseudo
function-call syntax in prompts and tool hints.
# Conflicts: # src/engine/prompt/system_prompt.cpp
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
合入 Claude 已完成的 GLM 工具调用恢复工作(b22418cf)。网关返回空工具名、调用表达式或损坏模板时,整步丢弃且不执行工具,最多重试一次;旧历史中的错误调用投影为未执行说明,避免连续重复未知工具错误。提示中的伪函数调用改为参数说明,并保留定时任务技能发现与禁止递归创建约束。
处理技能提示移动后的冲突,保留两侧功能;为 Chromium 110 浏览器测试中的 Playwright WebSocket 模拟补齐 URL.parse,产品代码不依赖此测试兼容。源 worktree 保持 clean 且原提交已正常推送,所有旧 ref/worktree 保留。
验证:Windows 全量 6,358 项执行(6,349 通过、9 跳过、另 1 原有禁用),0 失败;pnpm test、pnpm build;七项静态检查;102 项重构工具自测。侧栏、回答卡片和侧边聊天完成真实浏览器验证,侧边聊天在 Chromium 110/153 均通过。