Repository navigation
Fix first-run office invitation and guided tour deadlock - #111
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a clean profile in v0.9.37, the native Office welcome claim can resolve after the guided tour starts preparing. The queued invitation blocked the tour while also waiting for the tour to finish, so neither startup surface appeared despite welcome acknowledgement.
Only a visible Office invitation now blocks the guided tour. An already preparing/running tour finishes first, then the queued invitation appears. Added regression coverage exercises the interaction with the existing tour preparation policy.
Validation: full pnpm test and production build passed. An isolated Windows v0.9.37 native process using the corrected Web build passed automatic invitation display, dismissal without enabling, once-only claim, snapshot/title delivery, close persistence and reopening. Existing v0.9.37 package job was cancelled and the provisional update entry withdrawn; the published tag is unchanged pending explicit repair authorization.