ImportExportWorker: Log at the info log level - #363
Closed
chenxiaolong wants to merge 1 commit into
Closed
Conversation
Debug/verbose messages are currently intentionally stripped out of release builds, which make it more difficult to troubleshoot job scheduling issues. Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Owner
|
Thanks! Can you explain in more detail the rationale for this? In general, we just tell people who experience problems to reproduce them with debug builds - is there a reason why these log messages in particular should be included in release builds? |
Contributor
Author
|
Ah, I overlooked that in the README. If that's the case, we can probably just close this then. |
Owner
|
Okay, I think I'll close this without merging, then. As always, I greatly appreciate your help, and we can revisit adding more logging to release builds if there seems to be a need for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debug/verbose messages are currently intentionally stripped out of release builds, which make it more difficult to troubleshoot job scheduling issues.