Add r8/proguard rules for JNA - #358
Merged
Merged
Conversation
JNA's Android .aar artifact doesn't include any r8/proguard rules.
According to their FAQ [1], application developers are expected to copy
and paste the 4 rules into their proguard configs. Without these rules,
SodiumAndroid() initialization would fail because JNA's initialization
can't find the fields it needed via reflection with r8 renaming fields
to single letter names.
java.lang.UnsatisfiedLinkError: Can't obtain peer field ID for class com.sun.jna.Pointer
This only affected release builds since debug builds don't have r8
enabled.
[1] https://github.com/java-native-access/jna/blob/master/www/FrequentlyAskedQuestions.md#jna-on-android
Fixes: tmo1#357
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Contributor
Author
|
In my release build, the https://github.com/java-native-access/jna/blob/5.19.1/native/dispatch.c#L2872-L2875 couldn't find the field by name.
EDIT: JNA should really be providing a proguard config in their |
Owner
|
Thanks much! I tested extensively before comitting and releasing this - but only with debug builds :| |
Owner
|
To be fair to the LazySodium project, it does recommend adding these ProGuard rules in its own documentation, but I had missed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JNA's Android
.aarartifact doesn't include any r8/proguard rules. According to their FAQ [1], application developers are expected to copy and paste the 4 rules into their proguard configs. Without these rules,SodiumAndroid()initialization would fail because JNA's initialization can't find the fields it needed via reflection with r8 renaming fields to single letter names.This only affected release builds since debug builds don't have r8 enabled.
[1] https://github.com/java-native-access/jna/blob/master/www/FrequentlyAskedQuestions.md#jna-on-android
Fixes: #357