fix(react-wallet-kit): add missing jest-environment-jsdom devDep - #1474
Open
blockgroot wants to merge 1 commit into
Open
fix(react-wallet-kit): add missing jest-environment-jsdom devDep#1474blockgroot wants to merge 1 commit into
blockgroot wants to merge 1 commit into
Conversation
`src/tests/timers-test.ts` declares `@jest-environment jsdom`, but `jest-environment-jsdom` was never a devDependency of this package (only of the unrelated `telegram-cloud-storage-stamper` package), so the suite failed to run under pnpm's strict linking regardless of a full or scoped install. This went unnoticed because CI only runs a package's tests when turbo's affected-package filter includes it, and recent merges to main hadn't touched react-wallet-kit. Fixes tkhq#1473
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 332d8a2:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fixes #1473.
@turnkey/react-wallet-kit's test suite is broken:src/tests/timers-test.tsdeclareswhich requires
jest-environment-jsdomto be resolvable, but that package was never adevDependency of
react-wallet-kit— only of the unrelatedpackages/telegram-cloud-storage-stamper.Since the repo's
.npmrcsets no hoist pattern, pnpm's default strict linking means oneworkspace package can't resolve another's devDependency as a phantom dependency, so this
fails on both a full
pnpm install -rand a scoped--filterinstall.This has gone unnoticed because
.github/workflows/reusable-test.ymlrunspnpm test --filter="$(./.github/scripts/get-turbo-affected.sh ...)"— only packagesturbo considers affected by the current diff. None of the recent merges to
maintouchedreact-wallet-kit, so its test job was silently skipped every time.Fix: add
jest-environment-jsdom(matching the^29.7.0version already used bytelegram-cloud-storage-stamper) toreact-wallet-kit's devDependencies. No source orruntime change — this only makes the existing test declaration resolvable.
How I Tested These Changes
Before:
After:
Also ran
pnpm --filter @turnkey/react-wallet-kit buildandpnpm prettier --checkon thechanged files — both clean.
pnpm-lock.yamlchange is a hand-verified minimal 3-line addition (checked withpnpm install --frozen-lockfile --filter "@turnkey/react-wallet-kit...", which reported"Lockfile is up to date, resolution step is skipped" — no drift).
Did you add a changeset?
Yes —
.changeset/tame-otters-jsdom.md,@turnkey/react-wallet-kitpatch.