MFA and Scoped Sessions for SDK - #1240
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e1fdcb1:
|
2413c55 to
d1e89da
Compare
d1e89da to
1a37b07
Compare
157308e to
0278097
Compare
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
2892619 to
c91022e
Compare
6ac34b0 to
9bb8ef7
Compare
b145273 to
4519b40
Compare
| @@ -0,0 +1 @@ | |||
| Hello my name is readme | |||
There was a problem hiding this comment.
hello readme, my name is updateme!
| activityId: activityData.activity.id, | ||
| organizationId: activityData.activity.organizationId, | ||
| }, | ||
| stampWith |
There was a problem hiding this comment.
just flagging that this will be a bit awkward for passkeys and wallets because requests will require two stamps whenever MFA or consensus is needed
technically we already have this problem today with polling, it just hasn't really been a problem yet because we almost never have to poll (like 99% of the time)
if you want to stamp the request with a passkey or wallet but handle the MFA step using your session, that's still possible by doing:
stamp<Activity>()
sendSignedRequest()
4519b40 to
bf338cd
Compare
f49af3d to
d6c9783
Compare
d6c9783 to
fd88b78
Compare
| sessionKey?: string; | ||
| expirationSeconds?: string; | ||
| organizationId?: string; | ||
| sessionProfileId?: string; |
3 participants
Summary & Motivation
MFA and scoped sessions SDK integrations
Includes:
onMfaRequiredcallback inhttpClientonMfaRequired) in@turnkey/react-(native-)wallet-kit@turnkey/corethat gets auto-populated with anattestedIdentityafter callingverifyOtpor ahandlePROVIDEROauthfunctionreact-wallet-kit-playgroundexamplewith-mfa-scoped-sessionsexampleHow I Tested These Changes
locally
Did you add a changeset?
noooooooooo