Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/validate-external-composes.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@modular-css/processor": patch
---

Fail with `Invalid composes reference` when `composes: x from "file.css"` references a class that doesn't exist in that file, instead of crashing later with `composition is not iterable`.
10 changes: 10 additions & 0 deletions packages/processor/plugins/composition.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,16 @@ module.exports = () => ({
if(source) {
// External refs should already exist, so they don't get added
ref = selectorKey(source, name);

if(!files[source].classes[name]) {
const rel = relative(processor.options.cwd, source);

throw decl.error(
`Invalid composes reference, .${name} does not exist in ${rel}`, {
word: name,
}
);
}
} else if(global) {
ref = processor._addGlobal(name);
} else {
Expand Down
10 changes: 10 additions & 0 deletions packages/processor/test/composition.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,16 @@ describe("/processor.js", () => {
);
});

it("should fail if a composition references a non-existant class in another file", async (t) => {
await t.assert.rejects(
async () => processor.string(
path.join(__dirname, "specimens/invalid-external-composition.css"),
`.a { composes: nope from "./simple.css"; }`
),
/Invalid composes reference, \.nope does not exist in packages\/processor\/test\/specimens\/simple\.css/
);
});

it("should fail if a composition references a non-existant file", async (t) => {
await t.assert.rejects(
async () => processor.string(
Expand Down
Loading