Repository navigation
Limit manual production deploys to maintainers - #412
Merged
Merged
Conversation
Write access now lets the team deploy branches to staging. Merges reach production through ci; a hand-run deploy (redeploy or rollback) is limited to PROD_DEPLOYERS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github.actor keeps the original actor on a re-run, so a writer could re-run an old deploy (or only its failed production job) and put an older commit on production. Manual runs and re-runs now check github.triggering_actor in both jobs, and an automatic deploy only ships main's current tip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Follow-up from a security review of the first commit. Now:
Rollbacks are a maintainer's Run workflow with the SHA. Checked: an intern re-running an old automatic or manual deploy is refused; a maintainer's manual deploy or re-run, and the first automatic run after a merge, are allowed. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Write access now lets teammates (starting with our intern
hamitarsln) push branches tostagingand test there without approval. That access must not reach production.tin-lite-maintainersupdatemain.deploy's Run workflow (a prod redeploy or rollback) now refuses anyone not in thePROD_DEPLOYERSrepository variable (set to the four maintainers; only admins can change it). Merges still reach production automatically throughci.docs/staging.mdanddocs/repository-policy.mddescribe the setup.Verification
hamitarsln, a prefix of a listed name (egevsege-em), and an empty list are refused; CI-triggered runs are unaffected.Tested on staging
Workflow and docs only; nothing that runs on the VM changes. Deployed to staging by pushing to
staging, which also satisfies the required check.🤖 Generated with Claude Code