Repository navigation
Upload each deploy into its own private directory on the host - #407
Merged
Merged
Conversation
Fixed names in /tmp collide when a different account (a teammate, or the staging deploy workflow) deploys after you: the earlier files stay owned by their uploader and the next scp is refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy.sh uploaded to fixed names in /tmp. When a different account deployed next (a teammate, or the new deploy-staging workflow's service account), the earlier files were still owned by their uploader and scp was refused. This is the failure in the first deploy-staging runs after #406.
Each deploy now creates its own
mktemp -d /tmp/tin-deploy.XXXXXXXXXXon the host, uploads there, passes it toactivate_release.shasTIN_LITE_UPLOAD_DIR(validated;/tmpstill works for the old layout), and removes it afterwards whether or not the deploy succeeded.Verified: deployed this branch to staging with
TIN_LITE_DEPLOY_TARGET=staging infra/deploy.sh. Exit 0, both health checks passed, no upload directory left behind. The deploy-staging workflow is dispatched on this branch as a second check.🤖 Generated with Claude Code