Repository navigation
Plan and monitor Google Ads in the account's own currency - #402
Merged
Merged
Conversation
Google reads every amount in the account's currency, but launch and monitor treated them as dollars. A launch now reads the account's currency, pins one ECB reference rate, converts the plan's dollar figures once onto Google's minimum unit and shows both before approval. The monitor reports and proposes in that currency. Currencies Tin cannot price stop as unsupported_currency. Plans and proposals saved before this read as USD. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Google Ads reads every amount in the account's own currency (
CampaignBudget). Launch and monitor treated those amounts as dollars, so a $20 plan became ₺20 a day in a lira account. This replaces #400, which would have required USD accounts, with support for other currencies.gather:fx. A failed read is retryable and writes nothing.PLAN.mdand the approval summary show the account-currency amount, its dollar equivalent and the rate. The rate is pinned on the plan and incampaign.jsonand never converted again.unsupported_currencybefore any rate read, model call or write._usdfield names on Google Ads amounts are renamed, since they never were dollars.applyrefuses a plan whose currency differs from the account's. A dollar-planned campaign in a non-USD account gets acurrency_mismatchalert, plain cost reporting and no cost-based pauses or proposals.Verification
tests/test_paid_ads_currency.pycovers:campaign.jsonand proposal fixtures were kept as back-compat coverage.ads_currencyconverted $20 to €17.89, £15.11, ¥3,172 and ₹1,916.Notes
daily_budget_usd,cpc_ceiling_usd) stay in USD and are converted, with both amounts shown before approval. The assessment still reasons in USD.🤖 Generated with Claude Code