Repository navigation
fix: surface pending child reviews on X draft runs - #401
Open
hamitarsln wants to merge 1 commit into
Open
hamitarsln wants to merge 1 commit into
hamitarsln wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation matches the documented behavior and includes appropriate regression coverage.
0 open findings
What changed in this PR
Surfaces active X style-guide child reviews through parent run facts for HTTP and MCP.
Changes:
- Adds child review links and MCP “waiting for you” status.
- Suppresses links after the parent stops.
- Adds regression coverage and documentation.
| File | Description |
|---|---|
src/tin_lite/x_draft.py |
Projects pending child review links. |
src/tin_lite/mcp_server.py |
Exposes links and waiting status. |
src/tin_lite/api.py |
Supplies settings to shared facts. |
src/tin_lite/procedure_control.py |
Updates the facts call signature. |
tests/test_x_draft.py |
Tests active and stopped parents. |
docs/x-workflow.md |
Documents review handoff behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
An X draft waiting for its style guide review still said
workingin MCP, with no result link. The agent had to find and read the child run to learn where the review was.Return the child's review links from the shared HTTP/MCP facts. MCP shows
waiting for youand links to that guide. The parent still runs while it waits; approval belongs to the child. Stopped parents show no pending review link.Verification
Notes
No guide was approved and no post was sent. This fixes the review handoff, not a model/extract failure.