Repository navigation
fix: keep the reason when X style capture fails - #388
Closed
hamitarsln wants to merge 1 commit into
Closed
hamitarsln wants to merge 1 commit into
hamitarsln wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation preserves safe diagnostics, avoids provider-detail leakage, and maintains no-repurchase semantics.
0 open findings
What changed in this PR
Preserves safe X style extraction failure reasons while keeping retries idempotent and unknown provider details private.
Changes:
- Stores safe failure messages in the model effect receipt.
- Uses the stored reason when projecting run failure.
- Adds regression tests and documents the behavior.
| File | Description |
|---|---|
src/tin_lite/x_style_activities.py |
Persists and projects safe failure reasons. |
tests/test_x_style.py |
Tests known/unknown failures and retry behavior. |
docs/x-workflow.md |
Documents failure-message handling. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Superseded by #403, which keeps the X style capture reason through one shared failure classification (founder-fixable vs internal) instead of a per-workflow receipt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
X style extraction already reports known sampling, integration and billing errors. The failure handler replaces that reason with a generic message.
Save the safe message in the existing operation record and use it when marking the run failed. Unknown errors still hide private provider details. Retrying does not buy another request.
Verification
Notes
This fixes the missing error reason. It does not fix the underlying connected-account failure or claim a live provider test.