Skip to content

Top boundary reference and method - #179

Merged
dbrakenhoff merged 3 commits into
devfrom
top-boundary-reference-and-method
Sep 10, 2026
Merged

dbrakenhoff merged 3 commits into
devfrom
top-boundary-reference-and-method

Conversation

@dbrakenhoff

@dbrakenhoff dbrakenhoff commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Adds a reference to the top boundary element. Mostly useful for transient models to get access to top boundary element and inspect the top boundary condition. Also added to steady model to be consistent.

In steady, ml.aq.topbc or inhom.topbc holds reference to ConstantStar, AreaSinkInhom or XsectionAreaSinkInhom depending on the type of model/inhom.

In transient xsection.topbc holds reference to HstarXsection or AreaSinkXsection.

Adds method .get_bc() to transient element class to obtain time series of any .tsandbc which could be useful for plotting or comparison to other time series etc.

riv = tft.XsectionMaq(..., tsandhstar=[(0, 1), (1, 2), (2, 0)])
riv.topbc  # --> HstarXsection element

t = np.arange(0, 2, 0.1)
riv.topbc.get_bc(t)  # --> returns array of hstar values

- adds reference to top boundary element to steady/transient models (addition for steady is more for uniformity in code, not very useful)
- add get_bc method to element to create time series of topboundary condition (nice for plotting)
- move ConstantStar creation to Model base class for steady models
@dbrakenhoff
dbrakenhoff requested a review from mbakker7 September 9, 2026 08:47
@mbakker7

mbakker7 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

In the current transient code, aquifer 0 can be bounded on top by a leaky layer. If the topboundary='semi', then flow is semi-confined and in a cross-section model, tsandhstar can be specified to model a varying water table above the semi-confining top. But when topboundary='leak', then the top of the leaky layer is impermeable. This option is useful when a sand layer is covered by a clay layer and during a transient simulation water can leaky into or out of the clay layer. I don't think this option is used much (and probably poorly documented). But in this PR I get the idea that it is removed. Is that the case?

@dbrakenhoff dbrakenhoff mentioned this pull request Sep 9, 2026
4 of 5 tasks
@dbrakenhoff

Copy link
Copy Markdown
Contributor Author

But in this PR I get the idea that it is removed. Is that the case?

No, in timflow.steady there were references to the top being "leaky" which I think were never renamed to "semi"? In timflow.steady there are only two options, "conf" and "semi" so I modified the docs/error messages slightly to reflect that.

@mbakker7

mbakker7 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Sorry, I missed that. There is indeed no "leaky" in timflow.steady. So let's merge this.

@dbrakenhoff
dbrakenhoff merged commit 550c21a into dev Sep 10, 2026
11 checks passed
@dbrakenhoff
dbrakenhoff deleted the top-boundary-reference-and-method branch September 10, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants