Skip to content

fix: publish current VM RC on Pages #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tifycloud merged 1 commit into from
Jul 21, 2026
Merged

fix: publish current VM RC on Pages #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scripts/verify-pages-releases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,9 @@
"ARTIFACT_CLASS", "OPENWRT_VERSION", "TARGET", "MODE", "VM_ONLY",
"NOT_AX9000_FIRMWARE", "HARDWARE_VALIDATION", "NSS_VALIDATION",
"VALIDATION_SCOPE", "IMAGEBUILDER_URL", "IMAGEBUILDER_SHA256",
"RELEASE_TAG", "RELEASE_VERSION", "SSH_DEFAULT", "SSH_AUTHORIZED_KEYS",
"RELEASE_CONTRACT", "PUBLISHED_VARIANTS", "ESXI_VALIDATION",
"RELEASE_TAG", "RELEASE_VERSION", "RELEASE_CHANNEL", "PROJECT_COMMIT",
"SSH_DEFAULT", "SSH_AUTHORIZED_KEYS", "RELEASE_CONTRACT",
"PUBLISHED_VARIANTS", "ESXI_VALIDATION",
},
}
VM_SMOKE_REPORT_KEYS = {
Expand Down Expand Up @@ -811,6 +812,8 @@ def verify_vm_candidate(gh: Path, candidate: tuple[int, str, str, str, int, dict
if contract_version == VM_CONTRACT_V2:
expected_labels.update({
"RELEASE_CONTRACT": "vm-x86_64/v2",
"RELEASE_CHANNEL": "rc",
"PROJECT_COMMIT": source_digest,
"PUBLISHED_VARIANTS": VM_PUBLISHED_VARIANTS,
"ESXI_VALIDATION": "not-tested",
})
Expand Down
25 changes: 24 additions & 1 deletion tests/test_pages_provenance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,8 @@ def vm_evidence_payloads(version: str = "v0.1.0-rc.1", *,
else:
labels.update({
"RELEASE_CONTRACT": "vm-x86_64/v2",
"RELEASE_CHANNEL": "rc",
"PROJECT_COMMIT": "c" * 40,
"PUBLISHED_VARIANTS": module.VM_PUBLISHED_VARIANTS,
"ESXI_VALIDATION": "not-tested",
})
Expand Down Expand Up @@ -658,13 +660,34 @@ def fake_attestation(gh: Path, subject: Path, bundle: Path, tag: str, digest: st
"draft": False, "prerelease": False, "immutable": True, "published_at": "2026-07-19T02:00:00Z", "assets": [],
}
assert module.vm_candidate_assets(invalid_stable) is None
for key in ("RELEASE_CONTRACT", "PUBLISHED_VARIANTS", "ESXI_VALIDATION"):
assert len(module.VM_ARTIFACT_LABEL_KEYS[module.VM_CONTRACT_V2]) == 20
for key in (
"RELEASE_CONTRACT", "RELEASE_CHANNEL", "PROJECT_COMMIT",
"PUBLISHED_VARIANTS", "ESXI_VALIDATION",
):
expect_verification_error(
lambda key=key: verify_vm_fixture(
vm_evidence_payloads(contract_version=2, missing_label=key), contract_version=2,
),
f"v2 artifact labels accepted missing contract key: {key}",
)
for key, value in (
("RELEASE_CHANNEL", "stable"),
("PROJECT_COMMIT", "d" * 40),
):
expect_verification_error(
lambda key=key, value=value: verify_vm_fixture(
vm_evidence_payloads(contract_version=2, label_updates={key: value}), contract_version=2,
),
f"v2 artifact labels accepted an unbound contract value: {key}={value}",
)
expect_verification_error(
lambda: verify_vm_fixture(
vm_evidence_payloads(contract_version=2, label_updates={"UNSUPPORTED_LABEL": "true"}),
contract_version=2,
),
"v2 artifact labels accepted an unknown extra key",
)
for key in ("release_contract", "raw_bios_file", "iso_bios_qemu", "vmdk_efi_file", "esxi_validation"):
expect_verification_error(
lambda key=key: verify_vm_fixture(
Expand Down
Loading