Conversation
We're working with stream out from sql server, this implementation will improve it a lot.
Author
|
@tomhoule please take a look at this, it's very simple. With that way we should achieve something like this interation: let sql_meta: ResultMetadata;
let token_row : TokenRow = stream.into();
for column_index in sql_meta.columns().len() {
match token_row.get(column_index) {
// match column data types
}
} |
Contributor
|
Unfortunately I'm not the owner of this crate anymore. |
|
This pull request is very much needed Thanks @lpj145 |
Contributor
|
Unfortunately I'm also not the owner of this crate anymore either. |
joelparkerhenderson
added a commit
to mssql-rust/mssql-rust
that referenced
this pull request
Aug 29, 2026
Mirrors tiberius-rs/tiberius#331. Lets a Row streamed out of a SELECT be fed straight back into e.g. a bulk_insert send() without manually copying each cell. Implemented as From<Row> for TokenRow instead of the PR's Into<TokenRow> for Row: an Into-only impl with no matching From fails this fork's own `-D warnings` clippy gate (`clippy::from_over_into`), since an explicit From always gives you Into for free and the reverse isn't true. Added a live integration test: read a row out, convert it to a TokenRow, bulk_insert it back into the same table, and confirm both rows round-trip correctly. Verified live against a real SQL Server (Azure SQL Edge via rustls), plus: cargo check across all 6 CI feature combinations, cargo clippy --all-targets, cargo fmt --check, and cargo test --lib (153 passing). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0156Di1tRRLsJK8ctU1AmAJr
MattJackson
referenced
this pull request
in MattJackson/tiberius-ng
Aug 29, 2026
Adapted from upstream #331 (author @lpj145).
joelparkerhenderson
added a commit
to mssql-rust/mssql-rust
that referenced
this pull request
Aug 30, 2026
Mirrors tiberius-rs/tiberius#331. Lets a Row streamed out of a SELECT be fed straight back into e.g. a bulk_insert send() without manually copying each cell. Implemented as From<Row> for TokenRow instead of the PR's Into<TokenRow> for Row: an Into-only impl with no matching From fails this fork's own `-D warnings` clippy gate (`clippy::from_over_into`), since an explicit From always gives you Into for free and the reverse isn't true. Added a live integration test: read a row out, convert it to a TokenRow, bulk_insert it back into the same table, and confirm both rows round-trip correctly. Verified live against a real SQL Server (Azure SQL Edge via rustls), plus: cargo check across all 6 CI feature combinations, cargo clippy --all-targets, cargo fmt --check, and cargo test --lib (153 passing). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0156Di1tRRLsJK8ctU1AmAJr
This was referenced Sep 1, 2026
MattJackson
added a commit
that referenced
this pull request
Sep 3, 2026
MattJackson
added a commit
that referenced
this pull request
Sep 4, 2026
MattJackson
added a commit
that referenced
this pull request
Sep 6, 2026
MattJackson
added a commit
that referenced
this pull request
Sep 16, 2026
MattJackson
added a commit
that referenced
this pull request
Sep 24, 2026
Contributor
|
Included in #442 — shipped in tiberius v0.13.0. Thanks for this! Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're working with stream out from sql server, this implementation will improve it a lot.