Global: Use New MdePkg Definitions#977
Conversation
os-d
requested review from
SaiChaganty,
nate-desimone,
niruiyu and
samimujawar
as code owners
pierregondois
left a comment
pierregondois
left a comment
There was a problem hiding this comment.
Hello Oliver,
I could successfully build:
- ArmVExpress-FVP-AArch64.dsc
- Arm Juno
- IntelSiliconPkg.dsc
I could not build the Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc due to an unrelated build break, but the change look good to me.
NIT: It might still be worth splitting the patch Global: Use New PCI Definition in 2, one for Platform/Intel and one for Silicon/Intel. As the original modification is in the edk2 repo, it's not like it is possible to have one global patch to maintain synchronization and avoid a build breakage.
edk2 fixed the spelling error in PCI_CAPBILITY_POINTER_OFFSET. Fix this in edk2-platforms to match the new name. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
edk2 fixed the spelling error in PCI_CAPBILITY_POINTER_OFFSET. Fix it here. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
edk2 fixed the spelling error in an FF-A definition, update to use it. One of the changed files had two lines ending in LF instead of CRLF, so that is changed here as well to be all CRLF. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
os-d
force-pushed
the
mdepkg_spellcheck_fixes
branch
from
4f905d8 to
90ceae9
Compare
@pierregondois thanks for testing. I have split the first commit into two. |
3 participants
edk2 PR tianocore/edk2#12459 fixes spelling errors across MdePkg, including in definitions. Most of these do not affect edk2-platforms, but this PR uses the new definitions where applicable. It must be merged after the edk2 PR.