Skip to content

Features/ManageabilityPkg: Fix IPMI vulnerabilities and memory leak#973

Open
pohaosu wants to merge 1 commit intotianocore:masterfrom
pohaosu:fix-features-manageabilitypkg
Open

Features/ManageabilityPkg: Fix IPMI vulnerabilities and memory leak#973
pohaosu wants to merge 1 commit intotianocore:masterfrom
pohaosu:fix-features-manageabilitypkg

Conversation

@pohaosu
Copy link
Copy Markdown
Contributor

@pohaosu pohaosu commented Apr 4, 2026

Fix vulnerabilities and a memory leak in the IPMI Blob Transfer driver:

  • Prevent integer underflow and OOB read by validating response size before accessing CompletionCode, OEN, and CRC.
  • Prevent buffer overflow by ensuring BMC response size does not exceed the caller's buffer capacity, avoiding potential memory overwriting.
  • Fix memory leak by freeing IpmiResponseData and IpmiSendData.

Fix vulnerabilities and a memory leak in the IPMI Blob Transfer driver:
- Prevent integer underflow and OOB read by validating response size before
  accessing CompletionCode, OEN, and CRC.
- Prevent buffer overflow by ensuring BMC response size does not exceed the
  caller's buffer capacity, avoiding potential memory overwriting.
- Fix memory leak by freeing IpmiResponseData and IpmiSendData.

Signed-off-by: Phineas Su <pohaosu@google.com>
Copy link
Copy Markdown
Contributor

@abdattar abdattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait till below patch is merged
tianocore/edk2#12162
or make the changes on top of above PR's branch.

@pohaosu
Copy link
Copy Markdown
Contributor Author

pohaosu commented Apr 6, 2026

Thanks, @abdattar, I just sent a pr against @changab's fork.

@abdattar
Copy link
Copy Markdown
Contributor

abdattar commented May 5, 2026

Hi @pohaosu , ManageabilityPkg is now part of edk2 repo.
can you open separate PR against the master branch and close this PR?
Thanks
AbduL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants