KabylakeSiliconPkg: Fix mismatched function declaration#913
Open
mikebeaton wants to merge 1 commit intotianocore:masterfrom
Open
KabylakeSiliconPkg: Fix mismatched function declaration#913mikebeaton wants to merge 1 commit intotianocore:masterfrom
mikebeaton wants to merge 1 commit intotianocore:masterfrom
Conversation
mikebeaton
requested review from
ChaselChiu,
SaiChaganty and
nate-desimone
as code owners
On building Kabylake platforms in GCC5, we enounter (abbreviated):
SystemAgent/Library/PeiSaPolicyLib/MrcOemPlatform.c:610:1: error: conflicting types for ‘CheckPoint’
due to enum/integer mismatch; have ‘MrcStatus(void *, MrcOemStatusCommand, void *)’ [-Werror=enum-int-mismatch]
SystemAgent/Library/PeiSaPolicyLib/MrcOemPlatform.h:262:1: note: previous declaration of ‘CheckPoint’
with type ‘UINT32(void *, UINT32, void *)’ {aka ‘unsigned int(void *, unsigned int, void *)’}
Fix the header declaration to match the function definition, including
having the more specific enum types.
Signed-off-by: Mike Beaton <mjsbeaton@gmail.com>
mikebeaton
force-pushed
the
kaby-declaration
branch
from
d54cfeb to
154418e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On building Kabylake platforms in GCC5, we enounter (abbreviated):
SystemAgent/Library/PeiSaPolicyLib/MrcOemPlatform.c:610:1: error: conflicting types for ‘CheckPoint’ due to enum/integer mismatch; have ‘MrcStatus(void *, MrcOemStatusCommand, void *)’ [-Werror=enum-int-mismatch]
SystemAgent/Library/PeiSaPolicyLib/MrcOemPlatform.h:262:1: note: previous declaration of ‘CheckPoint’ with type ‘UINT32(void *, UINT32, void *)’ {aka ‘unsigned int(void *, unsigned int, void *)’}
Fix the header declaration to match the function definition, including having the more specific enum types.