Skip to content

Support adding downloads from manifest file #95

Description

@adowair

Problem

Today, Harbor only supports batch/bulk downloading by pasting a comma (or newline) delimited list of links. This modal quickly breaks when the user wishes to download a large manifest of files--Harbor hangs and consumes a lot of memory trying to absorb this huge clipboard "paste".

Goal

Introduce a new mechanism to add new Downloads via manifest file. At a minimum, a newline delimited file on disk should be selectable, and its constituent links parsed and added as downloads, without crashing Harbor.

Acceptance criteria

  • A new button "select manifest file" is available alongside the link text-input field in the Add Download modal
  • When the button is clicked, a Mac Finder window appears, prompting the user to select a manifest file
  • When such a file is selected, its path appears in the link text-input field, alongside some icon/indicator that it is a manifest file, not a single link
  • The rest of the flow continues: the modal shows at least the number of downloads to be added.
  • Care should be taken such that Harbor doesn't hog memory, as it does today when a large list is pasted into the input field.

Observed in Harbor 1.8.0

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions