fix: remove unused --typesBundle flag from seed-versions.sh#225
Merged
Conversation
The pinned @subsquid/substrate-metadata-explorer@1.1.2 does not support a --typesBundle option (it offers only --out, --archive, --chain), so 'make typegen-seed' / './scripts/seed-versions.sh' failed per network with 'error: unknown option --typesBundle' — masked by the script as a connection warning, ending with 0 versions discovered. The flag was never needed: the explorer fetches raw runtime metadata blobs over --chain; the types bundle is a typegen-side concern (decoding pre-V14 custom types), not required to capture metadata. Verified the bundle-free explorer output is byte-identical to the committed tfchainVersions.jsonl for all devnet versions, including pre-V14 (v49-v67). Keeps --chain (canonical chain RPC, no dependency on the archive). Also drops the now-orphaned TYPES_BUNDLE variable and its existence guard, which only existed to support the removed flag. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
make typegen-seed(and./scripts/seed-versions.sh) fails with the pinned@subsquid/substrate-metadata-explorer@1.1.2, which rejects--typesBundle(error: unknown option '--typesBundle'). The script masks this as a per-network connection warning and finishes having discovered 0 versions — so the documented reseed/recovery path silently does nothing.Why removing the flag is the right fix
The flag was never needed. The explorer just fetches raw runtime metadata blobs over
--chain; the types bundle is a typegen-side concern (decoding pre-V14 custom types), not required to capture metadata.Verified: bundle-free explorer output is byte-identical to the committed
tfchainVersions.jsonlfor all 62 devnet versions, including pre-V14 (v49–v67).Change
--typesBundle "$TYPES_BUNDLE"from the explorer call.TYPES_BUNDLEvariable and its existence-check guard (only existed to support the flag).--chain→ reseeds from the canonical chain RPC, no dependency on the archive.Note: the
--chainwalk is slow over public RPC (~5–15 min/network) — acceptable for a rare recovery operation; the script imposes no timeout and runs to completion.🤖 Generated with Claude Code