Simplify source classes - #285
Draft
jdbuhler wants to merge 7 commits into
Draft
Conversation
Quantities * type functions that iterate over their argument as taking an Iterable rather than a List * fix integration test to allow small numerical error in result
need to allocate a zero object and can do a sum over multiple components in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch cleans up the classes in the sources subdirectory. Changes include
One point_source integration test was updated to allow the result to differ by a very small amount (1e-15) from the analytically expected 1 as a result of using quad_vec().
It is my contention that the rewritten code is not slower than the original, more complex version. But I would appreciate suggestions on appropriate test cases to convincingly verify this hypothesis.
One data point so far: while testing cosipy with the updated ExtendedSource class using a model (Gassian_on_sphere) with a 2D spatial_shape with len(brightness) = 10, we found that call runs at about the same speed for 1000 spatial points and 3x faster for 10000 points.