Add multi-version Node.js testing to CI - #492
Merged
Merged
Conversation
Configure GitHub Actions to test on multiple Node.js versions: - Node.js 16.x (EOL but still in use) - Node.js 18.x (LTS) - Node.js 20.x (LTS) - Node.js 22.x (Current) Additional improvements: - Add browser tests to CI pipeline - Set fail-fast: false to test all versions - Add descriptive step names 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Focus on Node.js compatibility matrix testing only. Browser tests can be added to CI in a separate workflow later.
Node.js 16.x reached EOL in September 2023 and Vitest/Vite no longer support it (crypto.getRandomValues compatibility issue). Testing on actively supported LTS versions: - Node.js 18.x (Active LTS) - Node.js 20.x (Active LTS) - Node.js 22.x (Current)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configures GitHub Actions to test the WebSocket-Node library across multiple Node.js versions to ensure broad compatibility.
Node.js versions tested:
Additional CI improvements:
test:browser:chromium)fail-fast: falseto run all versions even if one failsTest coverage per Node.js version:
Test plan
This PR will automatically run the new multi-version CI workflow. Once GitHub Actions completes, we can verify:
Expected CI duration: ~5-7 minutes per Node.js version
🤖 Generated with Claude Code