Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
QA suite — refused, no regression specThis PR changes product source but adds no spec, so the suite was Source files changed with no matching spec |
|
Build for ⬇️ Download user-registration-5.3.1.zip (8.2M) 🚀 Try this PR in a live test site (a fresh WordPress opens in your browser with this build installed and you logged in as admin; it resets when you close the tab) Installs directly via Plugins → Add New → Upload Plugin. A later push only rebuilds this if its commit message includes |
There was a problem hiding this comment.
🟢 Approval recommended
The compatibility fixes are targeted, preserve existing behavior, and have no unresolved review issues.
No open issues 🎉
What changed in this PR
Fixes PHP 7.4 compatibility issues on older WordPress versions by replacing PHP 8-only str_contains() calls in membership field creation and settings parsing.
Changes:
- Replaces the membership field-name check with a PHP 7.4-compatible
strpos()check. - Replaces the settings option parsing check with a compatible
strpos()check. - Preserves behavior on newer supported environments.
| File | Description |
|---|---|
modules/membership/includes/Admin/Forms/class-ur-form-field-membership.php |
Prevents fatal errors during membership field creation on PHP 7.4. |
includes/functions-ur-core.php |
Prevents fatal errors while parsing settings option IDs on PHP 7.4. |
Review effort: Lite
All Submissions:
Changes proposed in this Pull Request:
On WordPress older than 5.9 with PHP 7.4, two spots could stop the site with a fatal error: saving some settings, and adding a membership field in the form builder. They now use a check that works on every supported version. Nothing changes for users on newer setups.
Part of themegrill/user-registration-pro#1963.
How to test the changes in this Pull Request:
Types of changes:
Other information:
Changelog entry
🤖 Generated with Claude Code