New icon - #24
Merged
Merged
New icon#24
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The icon generator fails when its destination directory does not already exist.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds application icon assets, runtime icon sizes, and rotated-log exclusions.
Changes:
- Adds 24px and 48px JavaFX icons.
- Adds a Swift generator for PNG, ICO, ICNS, and preview assets.
- Ignores rotated
*.log.*files.
File summaries
| File | Summary |
|---|---|
src/main/java/se/hirt/diskspace/App.java |
Loads additional icon sizes. |
scripts/generate-icons.swift |
Generates platform icon assets; destination directories must be created before writing. |
.gitignore |
Ignores rotated log files. |
Review details
Suppressed comments (1)
scripts/generate-icons.swift:194
icp6is the 48×48 ICNS element type, but this entry is populated with the 64×64 PNG. macOS may reject or misinterpret that representation, so use the generated 48×48 image here (the 64×64 Retina representation is already provided byic12).
let entries = [("icp4", 16), ("icp5", 32), ("icp6", 64), ("ic07", 128),
- Files reviewed: 3/14 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #12