Fixing deviceOf - #22
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect cross-mount filtering in the parallel directory scanner by correctly parsing the POSIX fileKey device ID as hexadecimal, preventing the scan from descending into virtual filesystems like /proc on Linux (issue #21).
Changes:
- Parse
fileKey’sdev=field explicitly as base-16 instead of usingLong.decode. - Make
deviceOfpackage-private to enable direct regression testing. - Add JUnit regression tests covering letter-containing hex devices, digit-only devices, and unparseable inputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/main/java/se/hirt/diskspace/scan/ParallelDirectoryScanner.java |
Fixes device ID parsing to keep root-device filtering enabled on Linux/macOS/BSD POSIX file keys. |
src/test/java/se/hirt/diskspace/scan/ParallelDirectoryScannerTest.java |
Adds regression tests to ensure deviceOf parses hex correctly and fails safely. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the accounting problem of #21.