Repository navigation
Fix a race when renaming a session - #3
Merged
Merged
Conversation
Dismissing the rename alert cleared AppModel.renaming to nil right away, but the Rename button's Task only read renaming after an await, by which point it was already gone — so renaming silently did nothing. Capture the prompt synchronously when the button is tapped instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppModel.renamingtonilright away, but the Rename button'sTaskonly readrenamingafter anawait, by which point it was alreadynil— so confirming a rename could silently do nothing.RenamePromptsynchronously in the button's action, before theTaskstarts, so it survives the dismissal.Test plan
swift buildsucceedsTaskhappens to win the race)🤖 Generated with Claude Code