Repository navigation
Conversation
Decorator tests only check that the field name is registered. Generate a schema from a read model and check the hidden field is not on the type. Fixes theam#701
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@nonExposedtests only check that the field name is stored on the config. This generates a GraphQL schema from a read model and checkssecretFieldis not on the type whilepublicFieldandidare.The fixture is copied onto its own config and removed from the shared
Magek.configbefore schema generation, and the generator's static schema cache is cleared afterward.Semver: no runtime change. The change file type is none.
Fixes #701
Test plan
cd packages/core && rushx test(330 passing)cd packages/core && rushx lint:fix