Repository navigation
Conversation
fetchEntitySnapshot wrote the loaded snapshot back when every pending event returned ReducerAction.Skip. That write copies the same data and does not move the snapshot cursor. Store a snapshot only when a reducer produced a new one. Fixes theam#700
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchEntitySnapshotstored the loaded snapshot again when every pending reducer returnedReducerAction.Skip, and also when a pending event was handed to the global error handler and processing continued. The stored copy keeps the oldsnapshottedEventCreatedAt, so the write does not move the snapshot forward. The method now returns the loaded snapshot and skips the write unless a reducer produced a new snapshot.A mix of skip and reduce still stores the reduced snapshot. An empty pending stream already returned without a write, and that path is unchanged.
Semver: patch. The method signature is the same. Callers see fewer snapshot writes when nothing changed.
Fixes #700
Test plan
storeSnapshotwas still called)cd packages/core && rushx test(332 passing)cd packages/core && rushx lint:fix