Repository navigation
Conversation
Filter and sort builders looked up non-exposed fields by the property name. Decorators store that list under the class name, and a nested class with no class decorator only keeps it on its own metadata. Those fields are now left out of the nested inputs. The shared class input type is unchanged. Fixes theam#702
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nested GraphQL filter and sort inputs were still offering fields marked
@nonExposed. The builders looked the exclusion list up by property name (address). Decorators store it under the class name (Address). A nested class that is not an entity, read model, command, or query never gets a config entry, so the list also has to be read from that class's own decorator metadata.The shared class input cache is filled without those exclusions. Query generation runs before mutations, and a stripped cached input would hide the field on command inputs as well.
Semver: patch. Method signatures are unchanged. Nested
*PropertyFilterand*PropertySortByinputs no longer include the hidden fields.Fixes #702
Test plan
internalCodewas still on the nested filter type)cd packages/core && rushx test(333 passing)cd packages/core && rushx lint:fix