Fix issues processing chromatin assay and genome annotation in scMultiome data (Signac) - #6
Open
randomForest97 wants to merge 5 commits into
Open
Fix issues processing chromatin assay and genome annotation in scMultiome data (Signac)#6randomForest97 wants to merge 5 commits into
randomForest97 wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issues processing chromatin assay and genome annotation in scMultiome data
I tried to use the package for scMultiome data and ran into several issues when processing the chromatin assay from Signac:
The chromatin assay had a different name than
"peaks". I added the option to specify the chromatin assay name explicitly.The code accessed the genome annotation via
obj@assays[["peaks"]]@annotation@seqinfo@genome[1], but if this value does not match"hg19","hg38","mm10"or"mm9", the corresponding GTF file was not copied. My data used"GRCm38", which caused the problem.The
GenomicRangespackage was not loaded, causing an error when creatingGRangesobjects, for example here:obj@assays[[chrom_assay_name]]@seqinfo, but in my case it was stored underobj@assays[[chrom_assay_name]]@annotation@seqinfo. I adapted the code to check both locations.