Skip to content

smaller fixes and simplifications - #44

Merged
jonas-fuchs merged 3 commits into
masterfrom
dev
Oct 8, 2026
Merged

jonas-fuchs merged 3 commits into
masterfrom
dev

Conversation

@jonas-fuchs

Copy link
Copy Markdown
Collaborator

This release fixes duplicate variant calls from overlapping feature matches and simplifies how the CLI selects rule-backed features. Generated profile plots also get a small readability update.

New features:

None.

Bug fixes:

  • VCF remapping now collapses duplicate variants projected to the same location and alleles from overlapping matches, keeping the best-scoring match. It also ties each query codon to the feature alignment that produced it, preventing codon-frame leakage between overlapping features.

Improvements:

  • Feature selection now uses a persisted has_rules flag and a rules-only alignment approach instead of suppressing ruleless overlapping features after annotation. Existing project databases are migrated automatically.
  • Profile plots use smaller, angled labels and slightly wider jitter spacing to improve readability.

Breaking changes:

None.

…rfs due to reverse and forward strand emitted codons; moreover removed ruleless feature supression logic in favor of a simple has feature flag in the database
@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.61017% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
respro/core/vcf_remap.py 96.55% 0 Missing and 1 partial ⚠️
respro/db/rules_import.py 83.33% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@jonas-fuchs
jonas-fuchs merged commit e1bffe3 into master Oct 8, 2026
11 of 12 checks passed
@jonas-fuchs
jonas-fuchs deleted the dev branch October 8, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant