Repository navigation
REF: Upgrade to ironlab 0.16 and remove the figure workarounds - #33
Merged
Merged
Conversation
Move every figure to ironlab 0.16.0 and drop the workarounds that 0.12 forced, recorded in thclark/ironlab#76-#80: - yfoil plot analysis draws Cp on a reversed axis instead of -Cp. - yfoil plot foil keeps equal aspect instead of limits widened from plot areas measured on 0.12 renders, has a curve key and a marker key of custom items, and cycles six dash patterns. - Key rows are fitted (fit_row) instead of hand-sized weights and trial PDF exports; a base or default case is drawn last but listed first on a row of its own; stacks sharing x show tick labels on the bottom row. - Aerofoil-series sheets share regular ticks and left-aligned titles, with the original titles restored. - Comparison sheets mark NaN values with axes-fraction ticks at the top edge, so the axes autoscale again, draw reference lines with hline/vline and set case names in monospace. - The transition-position strip names its rows by case on a categorical axis. - figures::save refuses a figure whose layout overflows a legend, clashes two entries or puts text off the page, without exporting a PDF. Build the branch-coverage branch map and case matrix as ironlab occupancy and cell figures in Rust (thclark/ironlab#74), and remove the matplotlib path (plot.py, studies/figures/) and the committed SVGs. The per-subroutine counts the matrix had in its margin are a published table, until ironlab has a table chart (thclark/ironlab#121). Regenerate every committed figure (schema 0.4 files are rejected), each study from the run its docs were published from so no table changes, and pin the docs' ironlab-web bundle to 0.16.0. Rename figure labels to tags after ironlab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves every yFoil figure to ironlab 0.16.0, removes the workarounds that 0.12 forced, and builds the branch-coverage occupancy figures with ironlab instead of matplotlib.
Workarounds removed
These were recorded in thclark/ironlab#76–#80:
yfoil plot analysis: Cp is drawn on a reversed axis (suction up) instead of −Cp.yfoil plot foil:hline/vline, which span the axes at any zoom.figures::saverefuses a figure whose layout overflows a legend, clashes two legend entries or puts text off the page. It checks withlayout_warnings(), without exporting a PDF.Not removed
Occupancy figures
The branch map and case × subroutine matrix are ironlab figures built in Rust (thclark/ironlab#74). The branch map uses
occupancyunder grouped category rows; the case matrix usescells, with turned monospace case labels and a panel colourbar.subroutine-counts.plot.py,studies/figures/(render.sh,style.py, the uv/matplotlib pin) and the two committed SVGs.Regenerated figures
Every committed
.figis regenerated, because files saved by 0.12 (schema 0.4) are rejected by 0.16:scripts/guide-figures.sh;cargo xtask publish, so no table numbers change;scripts/docs.sh, pinned to 0.16.0 with its checksum.All 52 figures load with no validation or layout warnings.
Figure "labels" are renamed to "tags", after ironlab.
docs/development/conventions/figures.md,CLAUDE.mdand the user guide are updated.Checks
-D warningson the workspace, andcargo fmt --checkci/no-deviations.shandscripts/docs-check.pyThe execution and subroutine suites were not run; nothing in them touches figures.