Repository navigation
ENH: Make bars a primitive and store how histograms were binned - #169
Merged
Merged
Conversation
Place each bar by its own position, offset, width and base, with its value as a length from the base and a margin beyond its end in the automatic limits, and remove bar groups, slots and gaps from the model. Add the bars helper, which writes the offsets, widths and bases of grouped and stacked series. Store the bin definition of a histogram on its bars, stairs or cells so that datatips report each bin's count and density. Record the decisions in ADRs 0026 to 0029.
thclark
added a commit
that referenced
this pull request
Oct 26, 2026
Place each bar by its own position, offset, width and base, with its value as a length from the base and a margin beyond its end in the automatic limits, and remove bar groups, slots and gaps from the model. Add the bars helper, which writes the offsets, widths and bases of grouped and stacked series. Store the bin definition of a histogram on its bars, stairs or cells so that datatips report each bin's count and density. Record the decisions in ADRs 0026 to 0029.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reworks stages 1 and 3 of the bars and histograms epic, following the design review on 2026-10-26.
Bars as a primitive
margin(default 0.05) extends the automatic value limits beyond the bar ends, so the tallest bar no longer touches the box.InconsistentBarGroupwarning.The
barshelperThe facade's
barshelper writes the offsets, widths and bases of grouped columns, stacked columns, and stacks side by side.Stored bin definitions
Bins,BinRuleandHistNormbecome model types.ADRs
The decisions are recorded in four ADRs:
Existing gallery figures render byte-identically.