Fix formatting inconsistencies#49
Open
luke560 wants to merge 1 commit into
Open
Conversation
Paldiu
requested changes
Jul 26, 2026
| if (reason != null) | ||
| msg( | ||
| player, | ||
| // We take advantage of the String blocks newline byte here because it's encoded by MiniMessage and preserved in display. |
Collaborator
There was a problem hiding this comment.
This is not intuitive to most people so I would please leave this in place or move it to a JavaDoc on the method
Author
There was a problem hiding this comment.
Then only people looking at this file will see the comment; I can put it back but imo it would be better to have this info available somewhere people would actually see it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing formatting inconsistencies from cmd system rewrite